Changeset 954
- Timestamp:
- 11/25/08 23:56:08 (3 years ago)
- Location:
- trunk
- Files:
-
- 7 edited
-
TWikiAjaxContrib/data/TWiki/TWikiAjaxContrib.txt (modified) (1 diff)
-
TWikiAjaxContrib/data/TWiki/TWikiAjaxContribExamples.txt (modified) (1 diff)
-
TWikiAjaxPlugin/lib/TWiki/Plugins/TWikiAjaxPlugin.pm (modified) (1 diff)
-
core/data/TestCases/TestCaseTWikiJavascripts.txt (modified) (12 diffs)
-
core/pub/System/JavascriptFiles/foswiki.js (modified) (2 diffs)
-
core/pub/System/JavascriptFiles/twikiForm.js (modified) (2 diffs)
-
core/pub/System/JavascriptFiles/twikiString.js (modified) (1 diff)
Legend:
- Unmodified
- Added
- Removed
-
trunk/TWikiAjaxContrib/data/TWiki/TWikiAjaxContrib.txt
r927 r954 412 412 <script type="text/javascript" src="%PUBURL%/%SYSTEMWEB%/YahooUserInterfaceContrib/build/connection/connection.js"></script> 413 413 <script type="text/javascript" src="%PUBURL%/%SYSTEMWEB%/JavascriptFiles/foswikilib.js"></script> 414 <script type="text/javascript" src="%PUBURL%/%SYSTEMWEB%/JavascriptFiles/ twikiArray.js"></script>414 <script type="text/javascript" src="%PUBURL%/%SYSTEMWEB%/JavascriptFiles/foswikiArray.js"></script> 415 415 <script type="text/javascript" src="%PUBURL%/%SYSTEMWEB%/TWikiAjaxContrib/twikiAjaxRequest.compressed.js"></script> 416 416 </verbatim> -
trunk/TWikiAjaxContrib/data/TWiki/TWikiAjaxContribExamples.txt
r927 r954 8 8 <script type="text/javascript" src="%PUBURL%/%SYSTEMWEB%/YahooUserInterfaceContrib/build/connection/connection.js"></script> 9 9 <script type="text/javascript" src="%PUBURL%/%SYSTEMWEB%/JavascriptFiles/foswikilib.js"></script> 10 <script type="text/javascript" src="%PUBURL%/%SYSTEMWEB%/JavascriptFiles/ twikiArray.js"></script>10 <script type="text/javascript" src="%PUBURL%/%SYSTEMWEB%/JavascriptFiles/foswikiArray.js"></script> 11 11 <script type="text/javascript" src="%PUBURL%/%SYSTEMWEB%/JavascriptFiles/twikiHTML.js"></script> 12 12 <script type="text/javascript" src="%PUBURL%/%SYSTEMWEB%/TWikiAjaxContrib/twikiAjaxRequest.compressed.js"></script> -
trunk/TWikiAjaxPlugin/lib/TWiki/Plugins/TWikiAjaxPlugin.pm
r927 r954 94 94 <script type="text/javascript" src="%PUBURL%/%SYSTEMWEB%/YahooUserInterfaceContrib/build/connection/connection.js"></script> 95 95 <script type="text/javascript" src="%PUBURL%/%SYSTEMWEB%/JavascriptFiles/foswikilib.js"></script> 96 <script type="text/javascript" src="%PUBURL%/%SYSTEMWEB%/JavascriptFiles/ twikiArray.js"></script>96 <script type="text/javascript" src="%PUBURL%/%SYSTEMWEB%/JavascriptFiles/foswikiArray.js"></script> 97 97 <script type="text/javascript" src="%PUBURL%/%SYSTEMWEB%/JavascriptFiles/twikiHTML.js"></script> 98 98 <script type="text/javascript" src="%PUBURL%/%SYSTEMWEB%/TWikiAjaxContrib/twikiAjaxRequest.compressed.js"></script> -
trunk/core/data/TestCases/TestCaseTWikiJavascripts.txt
r927 r954 12 12 %TOC% 13 13 14 ---++ twiki.Array15 <script language="javascript" src="%PUBURL%/%SYSTEMWEB%/JavascriptFiles/ twikiArray.js"></script>16 17 ---+++ twiki.Array.remove14 ---++ foswiki.Array 15 <script language="javascript" src="%PUBURL%/%SYSTEMWEB%/JavascriptFiles/foswikiArray.js"></script> 16 17 ---+++ foswiki.Array.remove 18 18 19 19 <script language="javascript"> … … 21 21 function testRemoveWithValidArgs() { 22 22 var list = ["a", "b", "c"]; 23 twiki.Array.remove(list, "b");23 foswiki.Array.remove(list, "b"); 24 24 assertEquals("Remove object 1 from list", "ac", list.join("")); 25 twiki.Array.remove(list, "a");25 foswiki.Array.remove(list, "a"); 26 26 assertEquals("Remove object 2 from list", "c", list.join("")); 27 twiki.Array.remove(list, "c");27 foswiki.Array.remove(list, "c"); 28 28 assertEquals("Remove object 3 from list", "", list.join("")); 29 29 } 30 30 function testRemoveWithInvalidArgs() { 31 31 var list = ["a", "b", "c"]; 32 assertNull("A null argument should result in null", twiki.Array.remove(list, null));33 twiki.Array.remove(list, null);32 assertNull("A null argument should result in null", foswiki.Array.remove(list, null)); 33 foswiki.Array.remove(list, null); 34 34 assertEquals("A null argument should result in no objects removed", "abc", list.join("")); 35 35 } 36 36 function testRemoveWithUndefinedValue() { 37 37 var list = ["a", "b", "c"]; 38 assertNull("An undefined argument should result in null", twiki.Array.remove(list, JSUNIT_UNDEFINED_VALUE));39 } 40 /*]]>*/ 41 </script> 42 43 ---+++ twiki.Array.convertArgumentsToArray38 assertNull("An undefined argument should result in null", foswiki.Array.remove(list, JSUNIT_UNDEFINED_VALUE)); 39 } 40 /*]]>*/ 41 </script> 42 43 ---+++ foswiki.Array.convertArgumentsToArray 44 44 45 45 <script language="javascript"> … … 50 50 function testConvertArgumentsToArrayWithValidArgs() { 51 51 var args = returnArguments("a", "b", "c"); 52 var argsArray = twiki.Array.convertArgumentsToArray(args);52 var argsArray = foswiki.Array.convertArgumentsToArray(args); 53 53 assertEquals("Convert valid arguments", "abc", argsArray.join("")); 54 var argsArray = twiki.Array.convertArgumentsToArray(args,1);54 var argsArray = foswiki.Array.convertArgumentsToArray(args,1); 55 55 assertEquals("Convert valid arguments with starting point", "bc", argsArray.join("")); 56 56 } … … 58 58 { 59 59 var args = returnArguments(); 60 var list = twiki.Array.convertArgumentsToArray(args);60 var list = foswiki.Array.convertArgumentsToArray(args); 61 61 assertNull("Empty args list should result in null", list); 62 62 } 63 63 { 64 64 var args = returnArguments("a", "b", "c"); 65 var list = twiki.Array.convertArgumentsToArray(args,3);65 var list = foswiki.Array.convertArgumentsToArray(args,3); 66 66 assertNull("Start beyond bounds should result in null", list); 67 67 } 68 68 { 69 assertNull("No args should result in null", twiki.Array.convertArgumentsToArray());69 assertNull("No args should result in null", foswiki.Array.convertArgumentsToArray()); 70 70 } 71 71 { 72 72 var args = returnArguments("a", "b", "c"); 73 var list = twiki.Array.convertArgumentsToArray(args,"a");73 var list = foswiki.Array.convertArgumentsToArray(args,"a"); 74 74 assertNull("String input as start should result in null", list); 75 75 } … … 79 79 </script> 80 80 81 ---+++ twiki.Array.indexOf81 ---+++ foswiki.Array.indexOf 82 82 83 83 <script language="javascript"> … … 88 88 var index; 89 89 90 index = twiki.Array.indexOf(array, "a");90 index = foswiki.Array.indexOf(array, "a"); 91 91 assertEquals("testIndexOfWithValidArgs 1", 0, index); 92 92 93 index = twiki.Array.indexOf(array, "b");93 index = foswiki.Array.indexOf(array, "b"); 94 94 assertEquals("testIndexOfWithValidArgs 2", 1, index); 95 95 96 index = twiki.Array.indexOf(array, "c");96 index = foswiki.Array.indexOf(array, "c"); 97 97 assertEquals("testIndexOfWithValidArgs 3", 3, index); 98 98 99 index = twiki.Array.indexOf(array, "d");99 index = foswiki.Array.indexOf(array, "d"); 100 100 assertEquals("testIndexOfWithValidArgs 4", -1, index); 101 101 102 102 var emptyArray = []; 103 index = twiki.Array.indexOf(emptyArray, "a");103 index = foswiki.Array.indexOf(emptyArray, "a"); 104 104 assertEquals("Empty array input should result in -1", -1, index); 105 105 } 106 106 function testIndexOfWithInvalidArgs() { 107 index = twiki.Array.indexOf(null, "a");107 index = foswiki.Array.indexOf(null, "a"); 108 108 assertNull("No array input should result in null", index); 109 109 } … … 149 149 </select> 150 150 151 <!-- select multi le -->151 <!-- select multiple --> 152 152 <select name="testSelectMultiple" size="5" multiple> 153 153 <option>[New Genre]</option> … … 205 205 206 206 207 ---+++ twiki.Form.makeSafeForTableEntry208 209 <script language="javascript">210 /*<![CDATA[*/211 212 function testMakeSafeForTableEntry() {213 {214 var form = document.getElementById('testForm');215 var formElem = document.getElementById('testInput');216 var testValue = "1111|2222";217 formElem.value = testValue;218 assertEquals("Before make safe", formElem.value, testValue);219 var EXPECTED = "1111/2222 ";220 221 twiki.Form.makeSafeForTableEntry( form );222 assertEquals("Before make safe", formElem.value, EXPECTED);223 224 }225 }226 227 /*]]>*/228 </script>229 230 231 207 232 208 ---++ twiki.HTML … … 242 218 /*<![CDATA[*/ 243 219 function testSetHtmlOfElementWithIdWithValidArgs() { 244 var html = "<span style=\"color:#00f\">Blue text<\/span>";220 var html = "<span class=\"blue\">Blue text<\/span>"; 245 221 var elem = twiki.HTML.setHtmlOfElementWithId( 246 222 "testSetHtmlOfElementWithId", … … 281 257 /*<![CDATA[*/ 282 258 function testSetHtmlOfElementWithValidArgs() { 283 var html = "<span style=\"color:#00f\">Blue text<\/span>";259 var html = "<span class=\"blue\">Blue text<\/span>"; 284 260 var elem = document.getElementById("setHtmlOfElement"); 285 261 var newElem = twiki.HTML.setHtmlOfElement( … … 304 280 305 281 function testSetHtmlOfElementWithInvalidArgs() { 306 var html = "<span style=\"color:#00f\">Blue text<\/span>";282 var html = "<span class=\"blue\">Blue text<\/span>"; 307 283 var newElem = twiki.HTML.setHtmlOfElement( 308 284 null, … … 1073 1049 </script> 1074 1050 1051 ---+++ twiki.String.makeSafeForTableEntry 1052 1053 <script language="javascript"> 1054 /*<![CDATA[*/ 1055 1056 function testMakeSafeForTableEntry() { 1057 var rawValue = "1111|2222"; 1058 var newValue = twiki.String.makeSafeForTableEntry( rawValue ); 1059 var EXPECTED = '1111/2222 '; 1060 assertEquals("Safe string", newValue, EXPECTED); 1061 } 1062 1063 /*]]>*/ 1064 </script> 1065 1075 1066 1076 1067 ---++ twiki.String (unicode chars) -
trunk/core/pub/System/JavascriptFiles/foswiki.js
r927 r954 5 5 Use the Foswiki library classes instead: 6 6 foswikilib.js 7 twikiArray.js7 foswikiArray.js 8 8 twikiCSS.js 9 9 twikiEvent.js … … 167 167 // Determine the first index of a string in an array. 168 168 // Return -1 if the string is not found. 169 // WATCH OUT: the refactored function in twiki.Array returns null with an169 // WATCH OUT: the refactored function in foswiki.Array returns null with an 170 170 // invalid array, but CSS class manipulation functions still rely on a 171 171 // return value of -1 -
trunk/core/pub/System/JavascriptFiles/twikiForm.js
r14 r954 1 1 /** 2 Requires twikiCSS.js 2 Requires twikiCSS.js and twikiString.js 3 3 */ 4 4 … … 148 148 case 'password': 149 149 case 'textarea': 150 formElem.value = twiki. Form._makeTextSafeForTableEntry(formElem.value);150 formElem.value = twiki.String.makeTextSafeForTableEntry(formElem.value); 151 151 break; 152 152 } 153 153 } 154 },155 156 /**157 Makes a text safe to insert in a TWiki table. Any table-breaking characters are replaced.158 @param inText: (String) the text to make safe159 @return table-safe text.160 */161 _makeTextSafeForTableEntry:function(inText) {162 if (inText.length == 0) return "";163 var safeString = inText;164 var re;165 // replace \n by \r166 re = new RegExp(/\r/g);167 safeString = safeString.replace(re, "\n");168 // replace pipes by forward slashes169 re = new RegExp(/\|/g);170 safeString = safeString.replace(re, "/");171 // replace double newlines172 re = new RegExp(/\n\s*\n/g);173 safeString = safeString.replace(re, "%<nop>BR%%<nop>BR%");174 // replace single newlines175 re = new RegExp(/\n/g);176 safeString = safeString.replace(re, "%<nop>BR%");177 // make left-aligned by appending a space178 safeString += " ";179 return safeString;180 154 }, 181 155 -
trunk/core/pub/System/JavascriptFiles/twikiString.js
r714 r954 76 76 if (!inValue) return null; 77 77 return twiki.String.removePunctuation(twiki.String.capitalize(inValue)); 78 }, 79 80 /** 81 Makes a text safe to insert in a Foswiki table. Any table-breaking characters are replaced. 82 @param inText: (String) the text to make safe 83 @return table-safe text. 84 */ 85 makeSafeForTableEntry:function(inText) { 86 if (inText.length == 0) return ""; 87 var safeString = inText; 88 var re; 89 // replace \n by \r 90 re = new RegExp(/\r/g); 91 safeString = safeString.replace(re, "\n"); 92 // replace pipes by forward slashes 93 re = new RegExp(/\|/g); 94 safeString = safeString.replace(re, "/"); 95 // replace double newlines 96 re = new RegExp(/\n\s*\n/g); 97 safeString = safeString.replace(re, "%<nop>BR%%<nop>BR%"); 98 // replace single newlines 99 re = new RegExp(/\n/g); 100 safeString = safeString.replace(re, "%<nop>BR%"); 101 // make left-aligned by appending a space 102 safeString += " "; 103 return safeString; 78 104 } 79 105 }
Note: See TracChangeset
for help on using the changeset viewer.
