Changeset 8899

Timestamp:

09/05/10 08:11:52 (21 months ago)

Author:

MichaelTempest

Message:

Item9514: Perl complained about join()-ing an undef value when opening the WYSIWYG editor. That seems to be because the splitting up of topic and URL params ended up accessing an array element that wasn't there.

I am not sure how to test the case where there are URL params, but I can open the wysiwyg editor again. Please feel free to fix this fix if I broke something :)

File:

• trunk/JQueryPlugin/lib/Foswiki/Plugins/JQueryPlugin/POPUPWINDOW.pm (modified) (1 diff)

trunk/JQueryPlugin/lib/Foswiki/Plugins/JQueryPlugin/POPUPWINDOW.pm

@@ -69 +69 @@
     if ($topic) {
         # get query string
-        my @urlParts = split(/\?/, $topic);
-        $topic = $urlParts[0] if scalar @urlParts;
-        push (@queryParts, $urlParts[1]) if scalar @urlParts;
+        if ( $topic =~ s/\?(.*)// ) {
+            push (@queryParts, $1);
+        }
     }