Changeset 871

Timestamp:

11/23/08 09:40:00 (4 years ago)

Author:

CrawfordCurrie

Message:

Item175: restore the module parameter to the plugin constructor; required by unit tests

Location:

trunk/core/lib/Foswiki

Files:

• Engine.pm (modified) (1 diff)
• Plugin.pm (modified) (2 diffs)

trunk/core/lib/Foswiki/Engine.pm

@@ -405 +405 @@
 =cut
 
-sub write { }
+sub write {
+    ASSERT('Pure virtual method - should never be called');
+}
 
 1;

trunk/core/lib/Foswiki/Plugin.pm

@@ -79 +79 @@
 =pod
 
----++ ClassMethod new( $session, $name )
+---++ ClassMethod new( $session, $name, [, $module] )
 
    * =$session= - Foswiki object
    * =$name= - name of the plugin e.g. MyPlugin
-
+   * =$module= - name of implementing package; optional, used for tests.
+     Normally =load= is used to discover the module from the config.
 =cut
 
 sub new {
-    my ( $class, $session, $name ) = @_;
+    my ( $class, $session, $name, $module ) = @_;
     my $this = bless( { session => $session }, $class );
 
@@ -93 +94 @@
     $name = Foswiki::Sandbox::untaintUnchecked($name);
     $this->{name}   = $name   || '';
+    if ( defined($module) ) {
+        $this->{module} = $module; # otherwise use discovery
+    }
 
     return $this;