Changeset 8648

Timestamp:

08/22/10 13:57:59 (18 months ago)

Author:

MichaelTempest

Message:

Item2286: The Foswiki class is spread over many different modules. Some modules put addition fields into the Foswiki session object, and some of those fields were not listed in finish(). I doubt these cause memory leaks, but at least finish() is more accurate now.

I also added an ASSERT that makes sure Foswiki::finish() *stays* accurate.

File:

• trunk/core/lib/Foswiki.pm (modified) (4 diffs)

trunk/core/lib/Foswiki.pm

@@ -2040 +2040 @@
     #}
     $_->finish() foreach values %{ $this->{forms} };
+    undef $this->{forms};
     $this->{plugins}->finish() if $this->{plugins};
     undef $this->{plugins};
@@ -2071 +2072 @@
     undef $this->{_zones};
     undef $this->{_renderZonePlaceholder};
+
     undef $this->{request};
+    undef $this->{cgiQuery};
+
     undef $this->{digester};
     undef $this->{urlHost};
@@ -2081 +2085 @@
     undef $this->{_EXT2ICON};
     undef $this->{_KNOWNICON};
+    undef $this->{_ICONSTEMPLATE};
     undef $this->{context};
     undef $this->{remoteUser};
@@ -2090 +2095 @@
     undef $this->{evaluating_if};
     undef $this->{_addedToHEAD};
+    undef $this->{sandbox};
+    undef $this->{evaluatingEval};
+
+    undef $this->{DebugVerificationCode}; # from Foswiki::UI::Register
+
+    if (DEBUG) {
+        my $remaining = join ',', grep {defined $this->{$_}} keys %$this;
+        ASSERT(0, "Fields with defined values in ".ref($this)."->finish(): ". $remaining) if $remaining;
+    }
 }