Changeset 8645

Timestamp:

08/22/10 13:06:48 (21 months ago)

Author:

CrawfordCurrie

Message:

Item9318: don't set the text on the saved topic until *after* the access controls have verified it's writable, otherwise we deny ourselves write access

File:

• trunk/core/lib/Foswiki/Func.pm (modified) (2 diffs)

trunk/core/lib/Foswiki/Func.pm

@@ -1547 +1547 @@
     ( $web, $topic ) = _validateWTA( $web, $topic );
     my $topicObject =
-      Foswiki::Meta->new( $Foswiki::Plugins::SESSION, $web, $topic, $text );
+      Foswiki::Meta->new( $Foswiki::Plugins::SESSION, $web, $topic );
 
     unless ( $topicObject->haveAccess('CHANGE') ) {
@@ -1555 +1555 @@
     }
 
+    # Set the new text and meta, now that access to the existing topic
+    # is verified
+    $topicObject->text( $text );
     $topicObject->copyFrom($smeta) if $smeta;
     return $topicObject->save(%$options);