Changeset 8604 for trunk/UnitTestContrib/test/unit/StoreTests.pm

Timestamp:

08/19/10 22:35:39 (3 years ago)

Author:

CrawfordCurrie

Message:

Item9487: changed the Meta object so that only one revision can be loaded into a meta object (though in extremis it can be unloaded again, though that's strongly discouraged). This minimises the risk that the meta object will be reloaded with an unexpected version as a side effect as an operation, such as a macro that employs a rev parameter. Thanks to MichaelDaum for identifying the problem, and pushing me to solve it - it's important that this is fixed before a 1.1 release. Note that this also contributes to resolving an issue I had stacked for 1.2 viz. how to cache and re-use meta objects. THE HIGHEST RISK in this checkin is the change to the Sandbox, which was required to return the stderr output from the co command, which is the only way I can find of determining the latest rev without a second fork to rlog

File:

• trunk/UnitTestContrib/test/unit/StoreTests.pm (modified) (1 diff)

trunk/UnitTestContrib/test/unit/StoreTests.pm

@@ -151 +151 @@
     $meta->remove('TOPICINFO');
     $readMeta->remove('TOPICINFO');
-    $meta->{_preferences} = $meta->{_session} = $readMeta->{_session} = undef;
-    $meta->{_preferences} = $meta->{_loadedRev} = $readMeta->{_loadedRev} =
-      undef;
+    foreach my $m ($meta, $readMeta) {
+        $m->{_preferences} = $m->{_session} =
+          $m->{_latestIsLoaded} = $m->{_loadedRev} = undef;
+    }
     $this->assert_deep_equals( $meta, $readMeta );
     my $webObject = Foswiki::Meta->new( $this->{session}, $web );