Changeset 8349

Timestamp:

07/29/10 14:16:20 (22 months ago)

Author:

CrawfordCurrie

Message:

Item8303: reverted out this fix, as it's incompatible with sorting by clicking on the footer rows of the table

Location:

trunk/TablePlugin

Files:

• data/System/TablePlugin.txt (modified) (3 diffs)
• lib/Foswiki/Plugins/TablePlugin.pm (modified) (1 diff)
• lib/Foswiki/Plugins/TablePlugin/Core.pm (modified) (2 diffs)

trunk/TablePlugin/data/System/TablePlugin.txt

@@ -9 +9 @@
    * Setting the background color and text color for data cells, for instance to get an alternating zebra pattern
    * Merging cells (row and col spans)
-
-Note: By default this plugin uses sorting that is performed on the server.
-If you can rely on Javascript being enabled in your browsers, then much
-better performance can be obtained with the Foswiki:Extensions.JQTablePlugin.
 
 %TOC%
@@ -178 +174 @@
 |  Release: | %$RELEASE% |
 |  Change History: | <!-- specify latest version first -->&nbsp; |
-|  28 Jul 2010 | 1.124: Fix sorting in multiple header rows |
 |  05 Apr 2010 | 1.123: New default colors. |
 |  13 Mar 2010 | 1.122: Arthur Clemens: Fixed sorting of columns with mixed data types: numbers, dates, strings, empty cells. |
@@ -213 +208 @@
 |  25 Oct 2006 | 1.015: Arthur Clemens: Added support for background colors of sorted column. Columns can be unsorted - sorting order is now: sort ascending, sort descending, unsort. Added attributes =headervalign= and =datavalign=. |
 |  16 Aug 2006 | Michael Daum: Added CSS support for even/odd table rows |
-|  13 Dec 2005 | Arthur Clemens: Added support for =id=, =summary= and =captione solid' |
+|  13 Dec 2005 | Arthur Clemens: Added support for =id=, =summary= and =caption= |
 |  05 Mar 2005 | 1.014: Crawford Currie eliminated deprecated handlers for Dakar |
 |  01 Aug 2004 | Arthur Clemens: Added CSS support for first column and ascending/descending table headers |

trunk/TablePlugin/lib/Foswiki/Plugins/TablePlugin.pm

@@ -10 +10 @@
 
 our $VERSION = '$Rev$';
-our $RELEASE = '1.124';
+our $RELEASE = '1.123';
 our $SHORTDESCRIPTION =
   'Control attributes of tables and sorting of table columns';

trunk/TablePlugin/lib/Foswiki/Plugins/TablePlugin/Core.pm

@@ -1505 +1505 @@
         if ($writingSortLinks) {
             $writingSortLinks = 0;
+            $sortLinksWritten = 1;
         }
 
@@ -1567 +1568 @@
             # each table heading
             $dataColorCount = 0;
-        } else {
-            $sortLinksWritten = 1;
         }