Changeset 8253

Timestamp:

07/20/10 08:32:19 (3 years ago)

Author:

CrawfordCurrie

Message:

Item9352: changed the hasAttachment method back to only testing the store for attachment existence. This means that the meta might have a 'handle' to an attachment that doesn't exist in the DB, which has the potential to be very confusing; but I can't fix this without compromising compatibility :-(

File:

• trunk/core/lib/Foswiki/Meta.pm (modified) (2 diffs)

trunk/core/lib/Foswiki/Meta.pm

@@ -2605 +2605 @@
 
 ---++ ObjectMethod hasAttachment( $name ) -> $boolean
-Test if the named attachment exists. Only valid on topics.
+Test if the named attachment exists. Only valid on topics. The attachment
+must exist in the store (it is not sufficient for it to be referenced
+in the object only)
 
 =cut
@@ -2613 +2615 @@
     ASSERT( $this->{_web} && $this->{_topic}, 'this is not a topic object' )
       if DEBUG;
-    return 1 if $this->{_session}->{store}->attachmentExists( $this, $name );
-
-    # Store denies knowledge of it; check the meta, just in case it's
-    # been added to meta but not saved yet
-    $this->reload(0) unless $this->latestIsLoaded();
-    return defined $this->get( 'FILEATTACHMENT', $name );
-
+    return $this->{_session}->{store}->attachmentExists( $this, $name );
 }