Changeset 8078

Timestamp:

07/08/10 20:41:19 (23 months ago)

Author:

MichaelTempest

Message:

Item1326: Give a more meaningful (and hopefully more helpful) explanation as to why selenium-based tests are being disabled

File:

• trunk/UnitTestContrib/test/unit/FoswikiSeleniumTestCase.pm (modified) (2 diffs)

trunk/UnitTestContrib/test/unit/FoswikiSeleniumTestCase.pm

@@ -99 +99 @@
     my @set = $this->SUPER::list_tests($suite);
 
+    unless ( $Foswiki::cfg{UnitTestContrib}{SeleniumRc}{Browsers} ) {
+        print STDERR "There are no browsers configured in "
+          . "\$Foswiki::cfg{UnitTestContrib}{SeleniumRc}{Browsers}, "
+          . "skipping Selenium-based tests\n";
+        return;
+    }
+
     if ( $this->{useSeleniumError} ) {
         print STDERR
-          "Cannot run Selenium-based tests: $this->{useSeleniumError}";
+          "Cannot run Selenium-based tests: $this->{useSeleniumError}\n";
         return;
     }
@@ -110 +117 @@
     my ( $this, $suite ) = @_;
 
+    unless ( $Foswiki::cfg{UnitTestContrib}{SeleniumRc}{Browsers} ) {
+
+        # Message is already reported from list_tests - no need to do it twice
+        return;
+    }
+
     if ( $this->{useSeleniumError} ) {
-        print STDERR
-          "Cannot run Selenium-based tests: $this->{useSeleniumError}";
+
+        # Message is already reported from list_tests - no need to do it twice
         return;
     }