Changeset 746

Timestamp:

11/16/08 20:35:21 (3 years ago)

Author:

OlivierRaginel

Message:

Item38: Removed backticks, removed 2 greps but lost one optimisation

File:

• trunk/core/tools/gendocs.pl (modified) (3 diffs)

trunk/core/tools/gendocs.pl

@@ -84 +84 @@
     return unless ( $file =~ /\.pm$/ );
 
-    my $count = `egrep -c '^=pod' $pmfile`;
-    return unless $count > 0;
+    # Babar: Removed optimisation on =pod as this parses the file twice
 
     my $package = $dir;
@@ -110 +109 @@
     my %spec;
     my $line;
+    my $howSmelly = 0;
 
     while( $line = <PMFILE>) {
+        $howSmelly++ if $Config->{smells} && $line =~ /(SMELL|FIXME|TODO)/;
         if( $line =~ /^=(begin|pod)/) {
             $inPod = 1;
@@ -152 +153 @@
     close(PMFILE);
 
-    my $howSmelly = "";
     if ( $Config->{smells} ) {
-        $howSmelly = `egrep -c '(SMELL|FIXME|TODO)' $pmfile`;
-        chomp($howSmelly);
         $smells += $howSmelly;
         if( $howSmelly) {