Changeset 744 for trunk/core/tools/check_manifest.pl

Timestamp:

11/16/08 20:35:10 (4 years ago)

Author:

OlivierRaginel

Message:

Item38: Removed backticks: Use File::Find and open,while(<>)

File:

• trunk/core/tools/check_manifest.pl (modified) (3 diffs)

trunk/core/tools/check_manifest.pl

@@ -3 +3 @@
 # cruise back up the tree until we find lib and data subdirs
 require Cwd;
+use File::Find;
 
 my @cwd = split(/[\/\\]/, Cwd::getcwd());
@@ -30 +31 @@
 my $manifest = 'lib/MANIFEST';
 unless (-f $manifest) {
-    $manifest = `find $root/lib/TWiki -name 'MANIFEST' -print`;
-    chomp $manifest;
+    File::Find::find( sub { /^MANIFEST\z/ && ( $manifest = $File::Find::name )
+                          }, "$root/lib/TWiki" );
 }
 die "No such MANIFEST $manifest" unless -e $manifest;
@@ -37 +38 @@
 my %man;
 
-map{ s/ .*//; $man{$_} = 1; }
-  grep { !/^!include/  }
-  split(/\n/, `cat $manifest` );
+open MAN, "< $manifest" or die "Can't open $manifest for reading: $!";
+while( <MAN> ) {
+    next if /^!include/;
+    $man{$1} = 1 if /^(\S+)\s+\d+$/;
+  }
+close MAN;
 
 my @lost;