Changeset 6770

Timestamp:

03/18/10 06:17:25 (2 years ago)

Author:

KennethLavrsen

Message:

Item1440: Form: get find category template twikicatitems error in foswiki warning log file
I do not want to remove the compatibility code as it is useful for people upgrading to Foswiki
who has webs from Beijing that still have this old way of doing forms.
But I bet most live with not having this to work and have not also copied some old template
to Foswiki. And then we should not flood their warning logs. It is about time we just stay
quiet about it.
And when the meta code was refactored from Store to Meta the coder did a detox he should not
have done. This is one place where the old name is used to detect the old topic format so
it must remain as it was

Location:

trunk/core/lib/Foswiki

Files:

• Compatibility.pm (modified) (1 diff)
• Meta.pm (modified) (3 diffs)

trunk/core/lib/Foswiki/Compatibility.pm

@@ -196 +196 @@
     }
     else {
-        $session->logger->log( 'warning',
-            "Form: get find category template twikicatitems for Web $web" );
+        # We used to log a warning but it only made noise and trouble
+        # People will not need to be warned any longer. Item1440
     }
     return $text;

trunk/core/lib/Foswiki/Meta.pm

@@ -2975 +2975 @@
     # If there is no meta data then convert from old format
     if ( !$this->count('TOPICINFO') ) {
-        if ( $text =~ /<!--FoswikiAttachment-->/ ) {
+        # The T-word string must remain unchanged for the compatibility
+        if ( $text =~ /<!--TWikiAttachment-->/ ) {
             require Foswiki::Compatibility;
             $text = Foswiki::Compatibility::migrateToFileAttachmentMacro(
@@ -2981 +2982 @@
         }
 
-        if ( $text =~ /<!--FoswikiCat-->/ ) {
+        # The T-word string must remain unchanged for the compatibility
+        if ( $text =~ /<!--TWikiCat-->/ ) {
             require Foswiki::Compatibility;
             $text =
@@ -2992 +2994 @@
 
         # This format used live at DrKW for a few months
-        if ( $text =~ /<!--FoswikiCat-->/ ) {
+        # The T-word string must remain unchanged for the compatibility
+        if ( $text =~ /<!--TWikiCat-->/ ) {
             $text =
               Foswiki::Compatibility::upgradeCategoryTable( $this->{_session},