Changeset 5607

Timestamp:

11/24/09 15:19:23 (2 years ago)

Author:

DanielRohde

Message:

Item1652: fixed a performance issue reported by Ingo Kappler (thx Michael Daum); released v1.030

Location:

trunk/HolidaylistPlugin

Files:

• data/System/HolidaylistPlugin.txt (modified) (4 diffs)
• lib/Foswiki/Plugins/HolidaylistPlugin.pm (modified) (4 diffs)

trunk/HolidaylistPlugin/data/System/HolidaylistPlugin.txt

@@ -1 @@
-%META:TOPICINFO{author="ProjectContributor" date="1181041089" format="1.0" version="$Rev: 18103 $"}%
+%META:TOPICINFO{author="ProjectContributor" date="1181041089" format="1.0" version="$Rev: 18212 $"}%
 <!--
 This topic is part of the documentation for HolidaylistPlugin and is
@@ -309 +309 @@
         * Install required CPAN modules (e.g. =perl -MCPAN -e "install Date::Calc"= )
         * Download the ZIP file from the Plugin web (see below)
-        * Unzip ==%TOPIC%.zip== in your twiki installation directory. Content:
+        * Unzip ==%TOPIC%.zip== in your Foswiki installation directory. Content:
 | *File:* | *Description:* |
 | ==data/System/%TOPIC%.txt== | Plugin topic |
@@ -321 +321 @@
 
 |  Plugin Author: | TWiki:Main.PeterJones, TWiki:Main.DanielRohde |
-|  Plugin Version: | v1.030 (BETA) |
+|  Plugin Version: | v1.030 (24 Nov 2009) |
 |  Change History: | <!-- versions below in reverse order -->&nbsp; |
-|  v1.030 (BETA) | TWiki:Main.DanielRohde: improved INCLUDE support requested by Foswiki:Main.IngoKappler; added multi language support for entry definitions; fixed unknown language bug | 
+|  v1.030 (24 Nov 2009) | TWiki:Main.DanielRohde: improved INCLUDE support requested by Foswiki:Main.IngoKappler; added multi language support for entry definitions; fixed unknown language bug; fixed performance issue reported by Foswiki:Main.IngoKappler (thx Foswiki:Main.MichaelDaum) | 
 |  v1.029 (6 Mar 2009) | TWiki:Main.DanielRohde: changed some defaults (showmonthheader, monthheaderformat, headerformat); fixed alignments (statistics, monthheader); added maxheight attribute; allowed color definitions in icon fields |
 |  v1.026 (28 Oct 2008) | TWiki:Main.DanielRohde: added missing anchor in showoptions form action; added row color feature (new attributes: namecolors, rowcolors); added order feature (new attribute: order); added namepos attribute (place names left and/or right of a row) |
@@ -335 +335 @@
 |  v1.018 (25 Jul 2006) | TWiki:Main.DanielRohde: fixed periodic event bug; added navigation feature | 
 |  v1.017 (31 May 2006) | TWiki:Main.DanielRohde: fixed minor bug (periodic repeater) |
-|  v1.016 (27 Apr 2006) | TWiki:Main.DanielRohde: fixed some major bugs: deep recursion bug reported by TWiki:Main.ChrisHausen; exception handling bug (concerns Dakar) |
-|  v1.015 (9 Feb 2006) | TWiki:Main.DanielRohde: added class attribute (holidaylistPluginTable) to table tag for stylesheet support (thanx TWiki:Main.HaraldJoerg and TWiki:Main.ArthurClemens); fixed mod_perl preload bug (removed 'use warnings;') reported by Foswiki:Main.KennethLavrsen |
+|  v1.016 (27 Apr 2006) | TWiki:Main.DanielRohde: fixed some major bugs: deep recursion bug reported by TWiki:Main.ChrisHausen; exception handling bug (concerns Foswiki) |
+|  v1.015 (9 Feb 2006) | TWiki:Main.DanielRohde: added class attribute (holidaylistPluginTable) to table tag for stylesheet support (thanx TWiki:Main.HaraldJoerg and Foswiki:Main.ArthurClemens); fixed mod_perl preload bug (removed 'use warnings;') reported by Foswiki:Main.KennethLavrsen |
 |  v1.014 (23 Jan 2006) | TWiki:Main.DanielRohde: incorporated documentation fixes by Foswiki:Main.KennethLavrsen (Bugs:Item1440) | 
 |  v1.013 (8 Nov 2005) | TWiki:Main.DanielRohde: added Perl strict pragma; | 

trunk/HolidaylistPlugin/lib/Foswiki/Plugins/HolidaylistPlugin.pm

@@ -48 +48 @@
     );
 
-# This should always be $Rev: 18103 $ so that TWiki can determine the checked-in
+# This should always be $Rev: 18212 $ so that Foswiki can determine the checked-in
 # status of the plugin. It is used by the build automation tools, so
 # you should leave it alone.
-$VERSION = '$Rev: 18103 $';
+$VERSION = '$Rev: 18212 $';
 
 # This is a free-form string you can use to "name" your own plugin version.
@@ -70 +70 @@
 #$REVISION = '1.018'; #dro# fixed periodic event bug; added navigation feature
 #$REVISION = '1.017'; #dro# fixed minor bug (periodic repeater)
-#$REVISION = '1.016'; #dro# fixed some major bugs: deep recursion bug reported by TWiki:Main.ChrisHausen; exception handling bug (concerns Dakar)
-#$REVISION = '1.015'; #dro# added class attribute (holidaylistPluginTable) to table tag for stylesheet support (thanx TWiki:Main.HaraldJoerg and TWiki:Main.ArthurClemens); fixed mod_perl preload bug (removed 'use warnings;') reported by Foswiki:Main.KennethLavrsen
+#$REVISION = '1.016'; #dro# fixed some major bugs: deep recursion bug reported by TWiki:Main.ChrisHausen; exception handling bug (concerns Foswiki)
+#$REVISION = '1.015'; #dro# added class attribute (holidaylistPluginTable) to table tag for stylesheet support (thanx TWiki:Main.HaraldJoerg and Foswiki:Main.ArthurClemens); fixed mod_perl preload bug (removed 'use warnings;') reported by Foswiki:Main.KennethLavrsen
 #$REVISION = '1.014'; #dro# incorporated documentation fixes by Foswiki:Main.KennethLavrsen (Bugs:Item1440) 
 #$REVISION = '1.013'; #dro# added Perl strict pragma; 
@@ -119 +119 @@
     Foswiki::Func::writeDebug( "- ${pluginName}::commonTagsHandler( $_[2].$_[1] )" ) if $debug;
 
+    return if Foswiki::Func::getContext()->{'save'};
+
     # This is the place to define customized tags and variables
     # Called by Foswiki::handleCommonTags, after %INCLUDE:"..."%
 
-    #### eval is bad because Dakar works with exceptions
+    #### eval is bad because Foswiki works with exceptions
     ####eval {
             $_[0] =~ s/%HOLIDAYLIST%/&handleHolidaylist("", $_[0], $_[1], $_[2])/ge;
@@ -1065 +1067 @@
                         
 
-                                # overwrite personal holidays with public holidays:
+                                # override personal holidays with public holidays:
                                 if ($options{enablepubholidays} && defined $$aptableref[$i]) {
                                         $icon = $iconstates{$$aptableref[$i]};