Changeset 5575

Timestamp:

11/18/09 12:21:02 (3 years ago)

Author:

MichaelDaum

Message:

Item2375:

• fixed use of undef value
• some minor optimizations

Location:

trunk/SetVariablePlugin

Files:

• data/System/SetVariablePlugin.txt (modified) (1 diff)
• lib/Foswiki/Plugins/SetVariablePlugin.pm (modified) (3 diffs)
• lib/Foswiki/Plugins/SetVariablePlugin/Core.pm (modified) (2 diffs)

trunk/SetVariablePlugin/data/System/SetVariablePlugin.txt

@@ -104 +104 @@
                and scope of the variable
 
----+++ DEBUGRULES
-Display a table of all definition rules as far as collected by SETVAR and UNSERVAR.
-
 ---++ Installation Instructions
 %$INSTALL_INSTRUCTIONS%

trunk/SetVariablePlugin/lib/Foswiki/Plugins/SetVariablePlugin.pm

@@ -24 +24 @@
 
 $VERSION = '$Rev: 4287 (2009-06-23) $';
-$RELEASE = '1.01';
+$RELEASE = '1.02';
 
 $SHORTDESCRIPTION = 'Flexible handling of topic variables';
 $NO_PREFS_IN_TOPIC = 1;
 
+use constant DEBUG => 0; #toggle me
 
 ###############################################################################
 sub initPlugin {
-  my( $topic, $web, $user, $installWeb ) = @_;
+  my ($topic, $web, $user, $installWeb) = @_;
 
   Foswiki::Func::registerTagHandler('SETVAR', \&handleSetVar);
@@ -38 +39 @@
   Foswiki::Func::registerTagHandler('DELVAR', \&handleUnsetVar);
   Foswiki::Func::registerTagHandler('UNSETVAR', \&handleUnsetVar);
-  Foswiki::Func::registerTagHandler('DEBUGRULES', \&handleDebugRules);
+  Foswiki::Func::registerTagHandler('DEBUGRULES', \&handleDebugRules) if DEBUG;
 
-  undef $core;
+  $core = undef;
 
   return 1;
@@ -56 +57 @@
 
 ###############################################################################
-sub handleSetVar { getCore()->handleSetVar(@_); }
+sub handleSetVar { 
+  getCore()->handleSetVar(@_) if Foswiki::Func::getContext()->{save} || DEBUG;
+  return '' ;
+}
+
+###############################################################################
+sub handleUnsetVar { 
+  getCore()->handleUnsetVar(@_) if Foswiki::Func::getContext()->{save} || DEBUG;
+  return '' ;
+}
+
+###############################################################################
 sub handleGetVar { getCore()->handleGetVar(@_); }
-sub handleUnsetVar { getCore()->handleUnsetVar(@_); }
 sub handleDebugRules { getCore()->handleDebugRules(@_); }
 sub beforeSaveHandler { getCore()->handleBeforeSave(@_); }

trunk/SetVariablePlugin/lib/Foswiki/Plugins/SetVariablePlugin/Core.pm

@@ -24 +24 @@
 sub new {
   my $class = shift;
-  my $this = bless({}, $class);
-
-  $this->{rules} = ();
-
-  return $this;
+
+  return bless({}, $class);
 }
 
@@ -56 +53 @@
 sub applyRules {
   my ($this, $web, $topic, $meta, $text) = @_;
+
+  return unless $this->{rules};
 
   $text ||= '';