Changeset 5375 for branches/Release01x00/core/lib/Foswiki.pm

Timestamp:

10/25/09 07:49:40 (3 years ago)

Author:

SvenDowideit

Message:

Item2286: lots of missing calls to Foswiki::finish(), will refactor in trunk - just cleaning in release branch

File:

• branches/Release01x00/core/lib/Foswiki.pm (modified) (3 diffs)

branches/Release01x00/core/lib/Foswiki.pm

@@ -1394 +1394 @@
     $query ||= new Foswiki::Request();
     my $this = bless( { sandbox => 'Foswiki::Sandbox' }, $class );
+
     $this->{request}  = $query;
     $this->{cgiQuery} = $query;    # for backwards compatibility in contribs
@@ -1766 +1767 @@
 =begin TML
 
+---++ ObjectMethod DESTROY()
+
+called by Perl when the Foswiki object goes out of scope
+(maybe should be used kist to ASSERT that finish() was called..
+
+=cut
+
+#sub DESTROY {
+#    my $this = shift;
+#    $this->finish();
+#}
+
+=begin TML
+
 ---++ ObjectMethod finish()
 Break circular references.
@@ -1779 +1794 @@
     $_->finish() foreach values %{ $this->{forms} };
     $this->{plugins}->finish()   if $this->{plugins};
+    undef $this->{plugins};
     $this->{users}->finish()     if $this->{users};
+    undef $this->{users};
     $this->{prefs}->finish()     if $this->{prefs};
+    undef $this->{prefs};
     $this->{templates}->finish() if $this->{templates};
+    undef $this->{templates};
     $this->{renderer}->finish()  if $this->{renderer};
+    undef $this->{renderer};
     $this->{net}->finish()       if $this->{net};
+    undef $this->{net};
     $this->{store}->finish()     if $this->{store};
+    undef $this->{store};
     $this->{search}->finish()    if $this->{search};
+    undef $this->{search};
     $this->{attach}->finish()    if $this->{attach};
+    undef $this->{attach};
     $this->{security}->finish()  if $this->{security};
+    undef $this->{security};
     $this->{i18n}->finish()      if $this->{i18n};
-
+    undef $this->{i18n};
+#TODO: the logger doesn't seem to have a finish...
+#    $this->{logger}->finish()      if $this->{logger};
+    undef $this->{logger};
+    
     undef $this->{_HTMLHEADERS};
     undef $this->{request};