Ignore:
Timestamp:
10/17/09 11:44:14 (3 years ago)
Author:
KennethLavrsen
Message:

Item1302: mailnotify ignores -news operand
It is a bug that goes back to TWiki 4.0. The -news was documented but never implemented
Fixing it as speced would cause trouble for people.
And the spec is bad. It would not work well. So instead of implenting a bad spec I decided to implement -nonews and -nochanges which will give people the flexibility AND maintain status quo for those already using the mailnotify with or without a -news switch on the cronjob.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • branches/Release01x00/MailerContrib/test/unit/MailerContrib/MailerContribSuite.pm

    r3661 r5288  
    358358 
    359359    my @webs = ( $this->{test_web}, $this->{users_web} ); 
    360     Foswiki::Contrib::MailerContrib::mailNotify( \@webs, $this->{twiki}, 0 ); 
     360    Foswiki::Contrib::MailerContrib::mailNotify( \@webs, $this->{twiki}, 0, 0, 0 ); 
    361361 
    362362    #print "REPORT\n",join("\n\n", @FoswikiFnTestCase::mails); 
     
    415415 
    416416    my @webs = ( $testWeb2, $this->{users_web} ); 
    417     Foswiki::Contrib::MailerContrib::mailNotify( \@webs, $this->{twiki}, 0 ); 
     417    Foswiki::Contrib::MailerContrib::mailNotify( \@webs, $this->{twiki}, 0, 0, 0 ); 
    418418 
    419419    #print "REPORT\n",join("\n\n", @FoswikiFnTestCase::mails); 
     
    542542        $meta, "Before\n${s}After", $meta ); 
    543543    Foswiki::Contrib::MailerContrib::mailNotify( [ $this->{test_web} ], 
    544         $this->{twiki}, 0 ); 
     544        $this->{twiki}, 0, 0, 0 ); 
    545545 
    546546    my %matched; 
     
    571571        $meta, "Before\n${s}After", $meta ); 
    572572    Foswiki::Contrib::MailerContrib::mailNotify( [ $this->{test_web} ], 
    573         $this->{twiki}, 0 ); 
     573        $this->{twiki}, 0, 0, 0 ); 
    574574 
    575575    my %matched; 
Note: See TracChangeset for help on using the changeset viewer.