Changeset 5269 for branches/Release01x00/MailerContrib/lib/Foswiki/Contrib/MailerContrib/CompatibilityHacks.pm

Timestamp:

10/15/09 19:28:59 (3 years ago)

Author:

KennethLavrsen

Message:

Item2260: MailerContrib cannot find email templates based on skin or web
The checkin does the following

• It makes a tiny little fix in MailerContrib.pm where I pushTopicContext before loading mail template and pop it again afterwards
• Updates the the documentation to show by example how to tailor the mail message
• Merge over the code from trunk. This introduces a bug fix from Item1603 which for some reason was only applied to trunk
• And with this merge also merge over a lot of perl tinying.

It was too difficult to separate the two once I was this far. Look at next checkin in trunk to see only the actual code changes

File:

• branches/Release01x00/MailerContrib/lib/Foswiki/Contrib/MailerContrib/CompatibilityHacks.pm (modified) (3 diffs)

branches/Release01x00/MailerContrib/lib/Foswiki/Contrib/MailerContrib/CompatibilityHacks.pm

@@ -4 +4 @@
 package IteratorHack;
 
+use strict;
+
 sub new {
-    my ($class, $list) = @_;
-    my $this = bless({list => $list, index => 0, next => undef }, $class);
+    my ( $class, $list ) = @_;
+    my $this = bless( { list => $list, index => 0, next => undef }, $class );
     return $this;
 }
 
 sub hasNext {
-    my( $this ) = @_;
+    my ($this) = @_;
     return 1 if $this->{next};
-    if( $this->{index} < scalar(@{$this->{list}}) ) {
-        $this->{next} = $this->{list}->[$this->{index}++];
+    if ( $this->{index} < scalar( @{ $this->{list} } ) ) {
+        $this->{next} = $this->{list}->[ $this->{index}++ ];
         return 1;
     }
@@ -31 +33 @@
 
 sub eachChangeSince {
-    my ($web, $since) = @_;
+    my ( $web, $since ) = @_;
 
     my $changes;
-    if( open(F, "<$Foswiki::cfg{DataDir}/$web/.changes")) {
+    if ( open( F, '<', "$Foswiki::cfg{DataDir}/$web/.changes" ) ) {
         local $/ = undef;
         $changes = <F>;
@@ -44 +46 @@
     my @changes =
       map {
-          # Create a hash for this line
-          { topic => $_->[0], user => $_->[1], time => $_->[2],
-              revision => $_->[3], more => $_->[4] };
+
+        # Create a hash for this line
+        {
+            topic    => $_->[0],
+            user     => $_->[1],
+            time     => $_->[2],
+            revision => $_->[3],
+            more     => $_->[4]
+        };
       }
-        grep {
-            # Filter on time
-            $_->[2] && $_->[2] >= $since
-        }
-          map {
-              # Split line into an array
-              my @row = split(/\t/, $_, 5);
-              \@row;
-          }
-            reverse split( /[\r\n]+/, $changes);
+      grep {
+
+        # Filter on time
+        $_->[2] && $_->[2] >= $since
+      }
+      map {
+
+        # Split line into an array
+        my @row = split( /\t/, $_, 5 );
+        \@row;
+      }
+      reverse split( /[\r\n]+/, $changes );
 
     return new IteratorHack( \@changes );