Changeset 497

Timestamp:

11/10/08 00:19:35 (3 years ago)

Author:

RobManson

Message:

Item38: Moved backticks to TWiki::Sandbox->sysCommand()

File:

• trunk/PageStatsPlugin/lib/TWiki/Plugins/PageStatsPlugin.pm (modified) (1 diff)

trunk/PageStatsPlugin/lib/TWiki/Plugins/PageStatsPlugin.pm

@@ -75 +75 @@
 
     my $dd = TWiki::Func::getDataDir();
-    my @pagestats = `grep $web\\.$topic $dd/log*.txt | grep -E \\(view\\|save\\)`;
+    #my @pagestats = `grep $web\\.$topic $dd/log*.txt | grep -E \\(view\\|save\\)`;
+    use TWiki::Sandbox;
+    my $sandbox = TWiki::Sandbox->new();
+    my ($lsresp, $lsexit) = $sandbox->sysCommand("ls -1 $dd");
+    my @resp = split(/\n/, $lsresp);
+    my @logs = grep(/log2.*.txt/, @resp);
+    my $logs = "";
+    foreach my $l (@logs) {
+        $logs .= "$dd/$l ";
+    }
+    my $pat = "$web.$topic";
+    my $x = 'grep -e '.$pat.' -e view -e save '.$logs;
+    my ($grepresp, $grepexit) = $sandbox->sysCommand('grep -e '.$pat.' -e view -e save '.$logs);
+    my @pagestats = split(/$/, $grepresp);
 
     my $maxEntries = scalar &TWiki::Func::extractNameValuePair( $attributes, "max" ) || scalar @pagestats;