Changeset 4839

Timestamp:

09/11/09 23:27:36 (2 years ago)

Author:

KennethLavrsen

Message:

Item8269: CommentPlugin: broken anchor target
The fix that was checked in assumed an anchor like pattern anywhere
An anchor must be at the beginning of a line on its own line
We want to allow white space after the anchor
If the anchor is not there we behave like no target is specified
If the target is another topic and a non-existng anchor we put the
comment at the end of the target topic.
This is what Sven implemented in Item727. His unit test was correct
But the Item727 code searched for anchors only at the first line
(missing /m in regex). Now I think it all works. Unit tests pass.

File:

• branches/Release01x00/CommentPlugin/lib/Foswiki/Plugins/CommentPlugin/Comment.pm (modified) (1 diff)

branches/Release01x00/CommentPlugin/lib/Foswiki/Plugins/CommentPlugin/Comment.pm

@@ -340 +340 @@
         undef $location;
     }
-    if ( defined($anchor) and $text !~ /$anchor/ ) {
+    if ( defined($anchor) and $text !~ /^$anchor\s*$/m ) {
         undef $anchor;
     }