Changeset 483 for trunk/TWikiReleaseTrackerPlugin/lib/TWiki/Plugins/TWikiReleaseTrackerPlugin/Commands.pm

Timestamp:

11/09/08 14:58:26 (4 years ago)

Author:

RobManson

Message:

Item38: Fixed up a load of legacy package/namespace issues so I could install it so I could test the changes I made to remove the backticks and replace them with ->sysCommand(). There's still an issue in TWikiReleaseTrackerPlugin.pm:137-139 with the Content-type. If you take this line out then twiki/bin/view/TWiki/TRTChangesFromDistribution gets sent as plain/text.

File:

• trunk/TWikiReleaseTrackerPlugin/lib/TWiki/Plugins/TWikiReleaseTrackerPlugin/Commands.pm (modified) (4 diffs)

trunk/TWikiReleaseTrackerPlugin/lib/TWiki/Plugins/TWikiReleaseTrackerPlugin/Commands.pm

@@ -71 +71 @@
 
 
-use FileDigest;
-use TRTConfig;
+use TWiki::Plugins::TWikiReleaseTrackerPlugin::FileDigest;
+use TWiki::Plugins::TWikiReleaseTrackerPlugin::TRTConfig;
 
 use TWiki;
@@ -86 +86 @@
 
 sub loadIndexes {
-    FileDigest::loadIndexes("pub/TWiki/TWikiReleaseTrackerPlugin");
+    TWiki::Plugins::TWikiReleaseTrackerPlugin::FileDigest::loadIndexes("pub/TWiki/TWikiReleaseTrackerPlugin");
 }
 
@@ -236 +236 @@
   unlink $filename;
   my $cmd = "zip ".$filename." ".join(" ", @files);
-  my $ans = `$cmd`;
+  #my $ans = `$cmd`;
+  my ($ans) = $sandbox->sysCommand($cmd);
   printIfVerbose($config, "$cmd:\n ".$ans);
   printIfVerbose($config, "File saved as ".$filename);
@@ -324 +325 @@
   my $command = join(" ", @_);
    
-  my $ans = `$command`;
+  #my $ans = `$command`;
+  my ($ans) = $sandbox->sysCommand($command);
   print $ans;