Changeset 3875 for trunk/WysiwygPlugin/lib/Foswiki/Plugins/WysiwygPlugin/HTML2TML.pm

Timestamp:

05/10/09 16:02:03 (3 years ago)

Author:

MichaelTempest

Message:

Item1535: Inserted span elements when WYSIWYG_TT class is applied to other elements. Added unit tests to replicate fault.

Also updated the internal test documentation in TranslatorTest.pm. (CDot: Thanks for explaining things)

Added explicit event handlers for each type of event generated by HTML::Parser, to eliminate the empty text elements generated from the start_document and end_document events. The default event handler should never be called, now.

File:

• trunk/WysiwygPlugin/lib/Foswiki/Plugins/WysiwygPlugin/HTML2TML.pm (modified) (2 diffs)

trunk/WysiwygPlugin/lib/Foswiki/Plugins/WysiwygPlugin/HTML2TML.pm

@@ -66 +66 @@
 
     my $this = new HTML::Parser(
-        start_h       => [ \&_openTag,  'self,tagname,attr' ],
-        end_h         => [ \&_closeTag, 'self,tagname' ],
-        declaration_h => [ \&_ignore,   'self' ],
-        default_h     => [ \&_text,     'self,text' ],
-        comment_h     => [ \&_comment,  'self,text' ]
+        start_h          => [ \&_openTag,  'self,tagname,attr' ],
+        end_h            => [ \&_closeTag, 'self,tagname' ],
+        text_h           => [ \&_text,     'self,text' ],
+        comment_h        => [ \&_comment,  'self,text' ],
+        declaration_h    => [ \&_ignore,   'self' ],
+        start_document_h => [ \&_ignore,   'self' ],
+        end_document_h   => [ \&_ignore,   'self' ],
+                default_h        => [ \&_default,  'self,event,text' ]
     );
 
@@ -220 +223 @@
 }
 
+sub _default {
+        my ( $this, $event, $text ) = @_;
+    # Unexpected $event event from HTML::Parser; text contains '$text'
+        ASSERT(0);
+}
+
 sub _apply {
     my ( $this, $tag ) = @_;