Changeset 14922

Timestamp:

05/29/12 10:38:14 (12 months ago)

Author:

CrawfordCurrie

Message:

Item11865: 'my' vars are local to the package and the module, and do not export to other modules declaring the same package

File:

• trunk/BuildContrib/lib/Foswiki/Contrib/Build.pm (modified) (2 diffs)

trunk/BuildContrib/lib/Foswiki/Contrib/Build.pm

@@ -44 +44 @@
 use Foswiki::Contrib::BuildContrib;
 
-our $basedir;
-our $buildpldir;
-our $libpath;
-
-my $VERSION;
-my $RELEASE;
+our $basedir;       # Calculated root i.e one above 'lib'
+our $buildpldir;    # Calculated location of build.pl
+our $libpath;       # $basedir/lib/
+
+our $VERSION;       # Version of BuildContrib
+our $RELEASE;       # Release of BuildContrib
 
 my $UPLOADSITEPUB           = 'http://foswiki.org/pub';
@@ -59 +59 @@
 my $FOSWIKIAUTHORSFILE      = 'core/AUTHORS';
 
-my $GLACIERMELT = 10;    # number of seconds to sleep between uploads,
-                         # to reduce average load on server
-my $lastUpload  = 0;     # time of last upload (0 means none yet)
-
-my $targetProject;       # Foswiki or TWiki
-
-my $collector;           # general purpose handle for collecting stuff
-
-my %minifiers;           # functions used to minify
+my $targetProject;    # Foswiki or TWiki
 
 # use diagnostics;