Changeset 13839 for branches/Release01x01/TWikiCompatibilityPlugin/lib/TWiki.pm

Timestamp:

01/27/12 06:04:41 (4 months ago)

Author:

PaulHarvey

Message:

Item11431: TWikiCompat, Don't Foswiki->new/finish

I don't understand why TWiki.pm needs to $query = undef here. Doing
that based on there being an undef $Foswiki::Plugins::SESSION makes
it impossible to create a new TWiki session object without violating
the one-instance-of-the-damn-singleton-at-a-time policy.

File:

• branches/Release01x01/TWikiCompatibilityPlugin/lib/TWiki.pm (modified) (1 diff)

branches/Release01x01/TWikiCompatibilityPlugin/lib/TWiki.pm

@@ -11 +11 @@
     if ( !$Foswiki::Plugins::SESSION && UNIVERSAL::isa( $query, 'CGI' ) ) {
 
-        # Compatibility: User gave a CGI object
-        # This probably means we're inside a script
-        $query = undef;
+        ## Compatibility: User gave a CGI object
+        ## This probably means we're inside a script
+        ## $query = undef;
+        # The above was added in Item689, Foswikirev:1847. It doesn't make any
+        # sense to me. PH disabled under Item11431 ('no singleton left behind')
     }
     my $fatwilly = new Foswiki( $loginName, $query, $initialContext );