Changeset 13791 for trunk/UnitTestContrib/test/unit/EmptyTests.pm

Timestamp:

01/23/12 06:00:05 (4 months ago)

Author:

PaulHarvey

Message:

Item11431: Clean UnitTests of Foswiki->new/finish

Committing what was 96 commits rebased on top of Foswikirev:13781. You
can view this full commit history at
 https://github.com/csirac2/UnitTestContrib/commits/Item11431-rebased

Tackling memory leaks, this effort seems to have saved 300MB and 10
minutes from the cost of running a full FoswikiSuite.

The recipe was:

• Find and remove all Foswiki->new/finish calls with $this->createNewFoswikiSession()
• Generally removed $fatwilly variables and replaced with $this->{session}, to avoid references to ->finish()'d Foswiki singleton/session objects
• Addressed perlcriticisms in touched files
• Convert Foswiki::Meta->new/load to Foswiki::Func::readTopic, for the sake of store2 re-integration
• Call $topicObject->finish() where/whenever we can

Some of the tests in the default plugins need a little work, and
there's some uncommitted stuff against core lib/Foswiki.pm to help
assert SINGLE_SINGLETONS from Foswiki::new/::finish subs, we'll get
to that later...

File:

• trunk/UnitTestContrib/test/unit/EmptyTests.pm (modified) (8 diffs)

trunk/UnitTestContrib/test/unit/EmptyTests.pm

@@ -1 @@
-use strict;
-
 # Example test case; use this as a basis to build your own
 
 package EmptyTests;
+use strict;
+use warnings;
 
 use FoswikiTestCase;
@@ -10 +10 @@
 use Foswiki;
 use Error qw( :try );
-
-my $topicquery;
 
 sub set_up {
@@ -20 +18 @@
     # You can now safely modify $Foswiki::cfg
 
-    $topicquery = new Unit::Request('');
+    my $topicquery = Unit::Request->new('');
     $topicquery->path_info('/TestCases/WebHome');
     try {
-        $this->{session} = new Foswiki( 'AdminUser' || '' );
+        $this->createNewFoswikiSession( 'AdminUser' || '' );
         my $user = $this->{session}->{user};
 
@@ -32 +30 @@
           Foswiki::Meta->new( $this->{session}, "Temporarytestweb1" );
         $webObject->populateNewWeb("_default");
+        $webObject->finish();
 
         # Copy a system web like this:
@@ -37 +36 @@
           Foswiki::Meta->new( $this->{session}, "Temporarysystemweb" );
         $webObject->populateNewWeb("System");
+        $webObject->finish();
 
         # Create a topic like this:
@@ -52 +52 @@
         $this->assert( 0, shift->stringify() || '' );
     };
+
+    return;
 }
 
@@ -61 +63 @@
     $this->removeWebFixture( $this->{session}, "Temporarytestweb1" );
     $this->removeWebFixture( $this->{session}, "Temporarysystemweb" );
-    $this->{session}->finish() if $this->{session};
 
     # Always do this, and always do it last
     $this->SUPER::tear_down();
+
+    return;
 }
 
@@ -77 +80 @@
 sub test_ {
     my $this = shift;
+
+    return;
 }